Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove whitespace pre-wrap in MultiMetricMouseoverLabel #3836

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Jan 11, 2024

In Safari, the inclusion of whitespace: pre-wrap appears to cause an issue where the value is placed incorrectly (see below). Removing this appears to maintain the intended placement in all browsers. However, it may have been added to address another visual issue.

Screenshot 2024-01-11 at 3 47 05 PM

@briangregoryholmes briangregoryholmes self-assigned this Jan 11, 2024
@briangregoryholmes briangregoryholmes changed the title remove whitespace pre-wrap remove whitespace pre-wrap in MultiMetricMouseoverLabel Jan 11, 2024
Copy link
Member

@djbarnwal djbarnwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't recall why it was added there. Did QA on the charts and didn't find any bugs.

@briangregoryholmes briangregoryholmes merged commit 26d6a1c into main Jan 11, 2024
6 checks passed
@briangregoryholmes briangregoryholmes deleted the safari-mouseover-fix branch January 11, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants