suggest models in the code editor #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangregoryholmes
changed the title
|
I started on QA, but I hit this error in my browser console, and it crashed the app: I have a |
ericpgreen2
reviewed
Dec 14, 2023
| allModels.data.map((r) => | ||
| createTableColumnsWithName(queryClient, instanceId, r.meta.name.name) | ||
| ), | ||
| (sourceColumnResponses) => |
There was a problem hiding this comment.
Ah, this tipped me off to where you got this code :). Nice approach to just mirror what we have for sources. But: sourceColumnResponses -> modelColumnResponses
|
@ericpgreen2 I missed that I moved the empty object assignment to the variable declaration, which resolved the issue on my end. |
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
* adds autocomplate for models in the code editor * remove unused type import * change schema initialization, rename variable in useAllModelColumns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3384
Like the idea of coloring sources and models differently, but this PR does not address that feature.