remove artificial time series chart delay #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… primaryTotal data is available (rather than both)
briangregoryholmes
changed the title
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
* update timeseries-data-store to return data as long as the primary or primaryTotal data is available (rather than both) * assign totals query a higher priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3381
Note: I did not have access to the dataset being used in the referenced Notion doc, so had to artificially recreate this situation while debugging.
The issue seems to be that TimeSeriesDataStore was artificially holding back data and returning
isFetchingastrueuntil both the totals and primary queries were available.During exploration, I saw no obvious UI issues related to rendering either of those pieces of data independently. As such, my proposed fix is to simply change the boolean logic of the
isFetchingproperty and remove the stricter "gate". This appears to solve the issue.This PR also updates the
totalsquery to a priority of 30.