Runtime: change reconcile and parse errors to warns #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
begelundmuller/refactor-conn-cache-open-close-background
to
main
December 15, 2023 11:29
k-anshul
approved these changes
Dec 15, 2023
Confirmed – these are still shown in the console |
begelundmuller
deleted the
begelundmuller/change-expected-errs-to-warns
branch
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Runtime: Refactor conn cache to contain and detect hanging opens/closes * Extract connection cache to pkg + use a singleflight * Add tests * Runtime: change reconcile and parse errors to warns
esevastyanov
pushed a commit
that referenced
this pull request
Dec 19, 2023
* Runtime: Refactor conn cache to contain and detect hanging opens/closes * Extract connection cache to pkg + use a singleflight * Add tests * Runtime: change reconcile and parse errors to warns (cherry picked from commit 50b4e2b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes error logs that can occur during normal usage to warning level. Examples of such errors include reconcile errors and revoked Github access.
By emitting these logs at warning level instead of error level, we reserve the error level for internal errors that are worth alerting on.