Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime: otel fix for db close leaks #3690

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Runtime: otel fix for db close leaks #3690

merged 5 commits into from
Dec 13, 2023

Conversation

k-anshul
Copy link
Member

  1. Fixes issue in otelsql which prevents duckDB close calls from being called properly which should hopefully fix OOM restarts.
  2. Upgrades otel to v0.26.0
  3. Removes extra code for detach all dbs before main duckDB handle close. Main handle can be closed without detaching attached DBs.

@k-anshul k-anshul self-assigned this Dec 13, 2023
@begelundmuller begelundmuller added blocker A release blocker issue that should be resolved before a new release and removed blocker A release blocker issue that should be resolved before a new release labels Dec 13, 2023
begelundmuller
begelundmuller approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – thanks!

@begelundmuller begelundmuller merged commit c24f3b4 into main Dec 13, 2023
4 checks passed
@begelundmuller begelundmuller deleted the otelfix branch December 13, 2023 13:48
mindspank pushed a commit that referenced this pull request Dec 18, 2023
@k-anshul @mindspank
Runtime: otel fix for db close leaks (#3690)
383f322 
* otel fix for db close leaks

* comment when to revert

* fix test case - wal doesn't exist

* otel pkgs upgrade and code changes

* deployment not found fix
esevastyanov pushed a commit that referenced this pull request Dec 19, 2023
@k-anshul @esevastyanov
Runtime: otel fix for db close leaks (#3690)
f265e64 
* otel fix for db close leaks

* comment when to revert

* fix test case - wal doesn't exist

* otel pkgs upgrade and code changes

* deployment not found fix

(cherry picked from commit c24f3b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees

@k-anshul k-anshul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-anshul @begelundmuller