svletecheck --ignore cleanup: fix most of "time-controls" folder #3651
Conversation
| (res.data?.meta?.stateUpdatedOn | ||
| ? res.data?.meta?.stateUpdatedOn > lastUpdatedOn | ||
| : undefined); | ||
|
|
There was a problem hiding this comment.
Not sure if we want to use undefined here. @ericpgreen2 would have more context.
There was a problem hiding this comment.
I'm not so familiar with this code (more @AdityaHegde), but it looks like it's fine as long as we protect against accessing an undefined attribute. And it looks like @bcolloran is doing so on line 154. After a quick look, line 154-155 is the only place where I see this changed attribute being used.
There was a problem hiding this comment.
good catch @djbarnwal, thank you. The current code is
!lastUpdatedOn || res.data?.meta?.stateUpdatedOn > lastUpdatedOn, and res.data?.meta?.stateUpdatedOn is string | undefined. Since undefined > x => false for all x: string, we should default to false here.
There was a problem hiding this comment.
(but that said we also return undefined for changed from this function on line 107 right above this: return { status: ResourceStatus.Busy })
* fix most of "time-controls" folder * change default return value to `false`
part of #3424
@djbarnwal -- assigning this review to you since you've worked on this stuff recently (I've also assigned #3678 to you to wrap this folder up). Thanks!