Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add timezone for dashboard.yaml #3463

Merged
merged 2 commits into from
Nov 13, 2023
Merged

docs: add timezone for dashboard.yaml #3463

merged 2 commits into from
Nov 13, 2023

Conversation

mindspank
Copy link
Contributor

Closes #3457

@mindspank mindspank added the Team:Applications Applications Working Group label Nov 12, 2023
@mindspank mindspank self-assigned this Nov 12, 2023
ericpgreen2
ericpgreen2 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. It'd also be nice to clarify that the available_time_zones key is required to make a dashboard timezone-aware and show the timezone selector. The comment about pinning makes it sound like it's just an aesthetic configuration.

@mindspank mindspank merged commit 8f93a89 into main Nov 13, 2023
2 checks passed
@mindspank mindspank deleted the doc/timezone branch November 13, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees

@mindspank mindspank

Labels
Team:Applications Applications Working Group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for available_timezones key in dashboard YAML
2 participants
@mindspank @ericpgreen2