Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D3 custom formatter #3268

Merged
merged 27 commits into from
Oct 19, 2023
Merged

D3 custom formatter #3268

merged 27 commits into from
Oct 19, 2023

Conversation

bcolloran
Copy link
Contributor

@bcolloran bcolloran commented Oct 18, 2023 •
edited
Loading

This PR enables the format_d3 option in the metrics definition, as well as simplifying and cleaning up a bunch of code along the way.

Example with an absurd d3 format string:

image

image

@bcolloran
remove percent-of-total on percent columns
87ec54f
@bcolloran
Merge branch 'main' into d3-custom-formatter
cd5c52e
@bcolloran
add selector for active measure FormatPreset, remove prop drilling
aac0ab6
@bcolloran
remove unused 'options' arg from humanizeDataType
8ef9314
@bcolloran
use d3 formatting in measure big nums
1cf8884
@bcolloran
d3 formatter working in leaderboards + cleanup
a9066b1
@bcolloran
clean up number formatting in LeaderboardListItem and context column
c368a9f
@bcolloran
move humanizing fns with rest of number formatting
500a885
@bcolloran
little cleanups
19889f2
@bcolloran
more cleanup and prop-drilling removal
442cffd
@bcolloran
more cleanup
de39370
@bcolloran
more cleanup
f57efa4
@bcolloran
Merge branch 'd3-custom-formatter' of https://github.com/rilldata/rill …
a2f3708 
…into d3-custom-formatter
@bcolloran
add d3 format in dimension tables, additional cleanup
f3c68b9
@bcolloran
remove never used slot from <MeasureChange>
466f0ef
@bcolloran
roll ProfileColumn into VirtualizedTableColumns, since it is never us…
2c21b10 
…ed independently
@bcolloran
add missing type
b0c6cd6
@bcolloran
remove the added "+" on string values of changes in the dimension tab…
cbfa7d9 
…le, does not work with d3 formatter enabled
@bcolloran
update doc
0ec0745
@bcolloran
clean up selector API
d5601f2
@bcolloran
cleanups
19580b8
@bcolloran
update docs
af67206
@bcolloran
use tailwind for styling
e619bbc
@bcolloran
use term "unabridged"
fd9e23b
@bcolloran
return empty string from measure value formatter if measureSpec is no…
1220945 
…t available
@bcolloran
consolidate number formatting code in one place
b02cd3c 
- associated cleanups
- remove an old `dev` folder item pointing at missing files
@bcolloran bcolloran requested a review from ericpgreen2 October 18, 2023 22:09
ericpgreen2
ericpgreen2 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is great! I have a few comments I'll leave in-line.

ericpgreen2
ericpgreen2 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put all the formatting utilities into one place? Maybe into lib/number-formatting? E.g., I see this PR touches:

  • features/dashboards/humanize-numbers.ts
  • lib/formatters.ts
  • lib/number-formatting/format-measure-value.ts

@ericpgreen2 ericpgreen2 mentioned this pull request Oct 19, 2023
Closed
38 tasks
ericpgreen2
ericpgreen2 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. IMO next thing that this feature needs is YAML validation (from the Platform side).

Approved!

@bcolloran bcolloran merged commit 07d69b5 into main Oct 19, 2023
3 checks passed
@bcolloran bcolloran deleted the d3-custom-formatter branch October 19, 2023 21:01
bcolloran added a commit that referenced this pull request Oct 19, 2023
@bcolloran
Revert "D3 custom formatter (#3268)"
5b01b9f 
This reverts commit 07d69b5.
bcolloran added a commit that referenced this pull request Oct 19, 2023
@bcolloran
Revert "D3 custom formatter (#3268)" (#3283)
ce46403 
This reverts commit 07d69b5.
@bcolloran bcolloran mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcolloran @ericpgreen2