Async reconcile UI Integration #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto adityahegde/async-reconcile-ui-global-listener
…ityahegde/async-reconcile-ui-snapshot
…hegde/async-reconcile-ui-snapshot
…hegde/async-reconcile-ui-final
…hegde/async-reconcile-ui-final
…hegde/async-reconcile-ui-final
begelundmuller
approved these changes
Sep 28, 2023
begelundmuller
merged commit 967e7ef
into
begelundmuller/async-reconcile-integration
3 of 4 checks passed
AdityaHegde
added a commit
that referenced
this pull request
Oct 10, 2023
* Create controllers for all instances; instance cache; Refactor package runtime * Adapt runtime/queries/ to use MetricsViewSpec * Old catalog backwards compatibility * Remove TriggerSync API * Implement wait until idle and ready * Move project parser config to instance * Add reconcile logging * Implement CreateTrigger * Backwards compatibility for PutXXXAndReconcile * Fix test error * Fix tests part 1 * Fix a bunch of race conditions * Better test utils * Source test * More extensive source testing * Fix linter * Fix more tests * Basic complete test working * More complete test * Fix test utils * Fix runtime package tests * Fix oversized SQL test failure * Misc fixes * Make rill start work * Increase sleep * Fix bug in catalog flush * Add missing timeline timer reset * Make catalog case insensitive * Hide kind qualifier from logs * Fix redundant delayed materializations * Ensure hydrating... log printed at top * Cleaner logging * Fix log ordering * Check ctx in catalog funcs * Fixed renames not getting enqueued * Misc fixes * Use every instead of ticker for refresh schedule yaml * Fix merge conflict * Handle init part 1 * Init part 2 * Rename dag2 -> dag * Fix linter * Fix model renames not turning into delete+create * Insert instead of upsert resources * Fix source model collision not removing model * Fix name collision restoration in Reparse * Add diff test * Add another reparse collision test case * Deduplicate buffered watcher paths * Don't use LongRunning for model views * Async reconcile UI Integration (#3118) * Adding name selector and updating sources * Updating models * Updating remaining references in sources and models * entity => resource * Updating dashboards to use the new API * Adding global invalidations * Updated selectors * Adding basic create/update of a source * Update create model and dashboard from source * Moving resource init into the store * Updating models to use the new API * Using parse errors * Initial commit for dashboard integration * Address previous PR comments * Improving the resource/file watchers * Fixing various issues * Adding wait for dashboard creation * Fixing a few more issues * Fixing basic actions * Fixing model and sources tests * Fixing errored dashboard navigation * Fixing the tests to a degree * Fixing the final tests * Fixing prettier * Fixing unit tests * Deterministic file watcher test * Use StateUpdatedOn in query cache key * Fix scheduling block on concurrent delete and rename * Fix subscriber close race condition * Adityahegde/async reconcile unit tests (#3148) * Adding some tests * Adding rename tests * Removing prints * Adding more rename tests * Adding remaining tests * Update tests * Remove unused code * Fix test import cycle * Fix a few more edge cases * Avoid ambiguous use of WaitUntilIdle * Fixing dashboard e2e tests * partner dashboard fixes * Async reconcile: admin and CLI integration (#3157) * Async reconcile: admin integration * Fix prettier * Fix return * Fixes * Async reconcile integration cloud fixes (#3163) * Fixing project listings * Some edge cases with errors * Fix undefined path in project errors * Fix prettier * Misc fixes * Make tests pass with -race * Adding a rudimentary temporary spinner for reconciling resources * Fixing linters * Fix prettier * Updating the reconciling message to include the item * Fix wait for initial hydration * Fixing view-as redirecting to editor on reset * Improving reconciling message * Remove some rillv1beta deps * Misc UI fixes * Treat self-referencing resources as cyclic * Log error for cyclic deps * Fix merge conflict * Drop V2 from resource kinds * Fixing errored model during source ingestion * Fix merge error * Fix async reconcile integration E2E stability (#3166) * Fix prettier * Removing log * Adding logs * Adding the correct e2e logs * Adding a retry to resource network call * Support keystroke-by-keystroke editing of rill.yaml (#3191) * Use incrementing ids for file watchers * Fix merge issues with sqlite * Fix sqlite catalogv2 * Fix tests * Extra safety in file watcher * Fix delayed materialization * Elaborate on existingTyp * Millisecond query cache --------- Co-authored-by: Aditya Hegde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working PR for integration the async reconcile API in UI
This is the final PR. For step by step changes check,
#3093
#3098
#3106
#3110
#3111
#3112