Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify connector source and sink props #3057

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Simplify connector source and sink props #3057

merged 5 commits into from
Sep 12, 2023

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Sep 11, 2023 •
edited
Loading

  • Removes source and sink types in favour of map[string]any
  • Enables moving property parsing out of reconcile into the connectors (needed for async reconcile)

@begelundmuller begelundmuller marked this pull request as ready for review September 11, 2023 17:56
k-anshul
k-anshul reviewed Sep 12, 2023
View reviewed changes
runtime/reconcilers/source.go Outdated
default:
return nil, fmt.Errorf("source connector %q not supported", conn.Driver())
}
// props["extract"] = src.Policy // TODO: add
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this todo can be removed as well.

@begelundmuller begelundmuller merged commit d44bd03 into main Sep 12, 2023
5 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/simplify-src-sink-props branch September 12, 2023 08:23
@begelundmuller begelundmuller mentioned this pull request Sep 12, 2023
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-anshul k-anshul k-anshul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@begelundmuller @k-anshul