Add "View as" button to Rill Cloud dashboards #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishantmonu51
added
the
blocker
nishantmonu51
approved these changes
Sep 14, 2023
nishantmonu51
added a commit
that referenced
this pull request
Sep 21, 2023
* Configure preserve_insertion_order (#3070) * Size based iterator for object stores (#3069) * linting * linting * slice.clone is in go1.21 * unused comment * fixing test * Cloud UI: Remove calls to `ListFiles` API (#3054) * Remove calls to `ListFiles` API * Fix `svelte-check` w/ explicit type * Add comment * Edit 404 copy * Better variable names * Make zoom on scrub more intutive (#3075) * Add zoom button on top of charts * Add option, remove menu * Restructure file * Less strict default range (#3064) * Move source properties backwards compatibility rules to drivers (#3072) * Move source properties backwards compatibility rules to drivers * Fix tests * Address review * Docs: remove "experimental" banner from security policies (#3078) * Add "View as" button to Rill Cloud dashboards (#3047) * Refactor `UserButton` * Add conditional 'View as' menu item * Add `svelte-headlessui` and `svelte-popperjs` * Add "View As" popover * Acquire and set JWT * Remove calls to `ListFiles` API * Fix `svelte-check` w/ explicit type * Add comment * Patch `MenuItem` component * Remove File API usage * Handle chip removal * Fix z-index on chip * Clear error when switching users * Switch back to admin's JWT * Handle 404 from `GetCatalog` * Add workaround for metrics view 401s; clean up * Clear mimicked user after navigation * Bugfix * Make the whole chip clickable * Add checkmark to denote active user * Remove comment * Edit 404 copy * Better variable names * Move code to `features/view-as-user` * Factor out a `ViewAsUserMenuItem` component * Use consistent "viewed as" terminology * Use consistent "view as" terminology (cont.) * Clean up actions * Nits * Bug fix * Use query cache * Remove unneccessary query observer * Handle case when admin's JWT gets refreshed * Make AcquireHandle work for any source connector (#3076) * Enable opening source connectors using AcquireHandle * Fix * Correct generic support for DuckDB source connector * Fix test * Add dimension comparison (#3053) * Initial comparison view * Add compare icon to selector * Initial feature * add new files * Fix post merge issues * Reorganize * Clean up comparison components * hook state to time controls * align text with icon * Do not remove comp on clearing filters * get top7, fix menu * Prettier fixes * Add icons to dimension table * Remove measure big num changes * Remove time comparison when toggled from leaderboard * Fix ui tests * Fix to work for custom dimension names * add new state to proto * Add search to comparison menu * Align all to right * Align icons with leaderboard values * Toggle comparison when compare icon in active state * Reduce whitespace in menu * Align all measures with big nums * Align controls icons * Rename selected to selectedIndex * rename showComparison to showTimeComparison * Add types to dimension query * Prettier fix * Add comparison button to dimension table * Batch state calls * Limit to 3 values by default * Support for exclude * Update exclude mode comparison icon for leaderboard * Don't show context on no comp/dim comp * Fix test * Reduce menu width * Leaderboard show all compared values for exclude * Hide labels if no current data * Fix icon warning * Fix buggy selection when values out of 250 * lint fix * https connector: add "uri" alias for "path" (#3080) * https connector: add backwards compatibility for "uri" * Always use "mapstructure" instead of "key" * DuckDB SQL sources for async reconcile (#3082) * Enable transporters to acquire arbitrary connections * Remove embedded sources from async reconcile * Implement sql source rewriting for new reconcile * Fix linter * Update runtime/drivers/duckdb/transporter/duckDB_to_duckDB.go * Update runtime/drivers/duckdb/transporter/duckDB_to_duckDB.go * Update runtime/drivers/duckdb/transporter/duckDB_to_duckDB.go * Add access policy checks for new resource API (#3083) * Add access policy checks for new resource API * Code review * Release 0.34 notes (#3081) * Release notes initial draft * Add BQ connector * remove double quotes * review comments * NON WORKING - Merge branch 'main' into sort-by-context-columns * remove quotes to be consistent with prev release notes (#3087) * fix merge conflicts * cleanups --------- Co-authored-by: Benjamin Egelund-Müller <[email protected]> Co-authored-by: Anshul Khandelwal <[email protected]> Co-authored-by: Eric P Green <[email protected]> Co-authored-by: Dhiraj Barnwal <[email protected]> Co-authored-by: Nishant Bangarwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "View as" button for project admins. It is used to simulate how another project user sees a dashboard, according to the dashboard's security policies. The button is located in the User Button menu and is (currently) only shown on dashboard pages.