Runtime: duckdb sqlite extensions based connector for sqlite #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
k-anshul
commented
Sep 4, 2023
•
k-anshul
commented
- Adds a sqlite connector
There was a problem hiding this comment.
Hey, I took a look at this PR and added some comments in Notion here
k-anshul
changed the title
begelundmuller
requested changes
Sep 13, 2023
begelundmuller
requested changes
Sep 14, 2023
begelundmuller
requested changes
Sep 25, 2023
| @@ -175,7 +175,7 @@ func (a *AST) traverseTableFunction(parent astNode, childKey string) { | |||
| case "read_csv_auto", "read_csv", | |||
| "read_parquet", | |||
| "read_json", "read_json_auto", "read_json_objects", "read_json_objects_auto", | |||
| "read_ndjson_objects", "read_ndjson", "read_ndjson_auto": | |||
| "read_ndjson_objects", "read_ndjson", "read_ndjson_auto", "sqlite_scan": | |||
There was a problem hiding this comment.
This seems weird – the value passed to sqlite_scan isn't really a path. Should we handle it as a separate case? And also check the callers to duckdbsql that they can handle sqlite table functions (they might assume it's a file right now).
Co-authored-by: Benjamin Egelund-Müller <[email protected]>
begelundmuller
added
the
blocker
begelundmuller
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.