tweak: autosave behavior in visual explore editor (#6208)

* tweak: autosave behavior in visual explore editor * remove unintended style
rilldata · Dec 5, 2024 · fbda995 · fbda995 · github-actions · Dec 5, 2024
1 parent 258151c
commit fbda995
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/web-common/src/features/explores/ExploreEditor.svelte b/web-common/src/features/explores/ExploreEditor.svelte
@@ -13,6 +13,7 @@
   export let fileArtifact: FileArtifact;
   export let autoSave: boolean;
   export let lineBasedRuntimeErrors: LineStatus[];
+  export let forceLocalUpdates = false;
 
   let editor: EditorView;
 
@@ -21,6 +22,7 @@
 </script>
 
 <Editor
+  {forceLocalUpdates}
   bind:autoSave
   bind:editor
   onSave={(content) => {

diff --git a/web-common/src/features/workspaces/ExploreWorkspace.svelte b/web-common/src/features/workspaces/ExploreWorkspace.svelte
@@ -109,6 +109,7 @@
         {exploreName}
         {fileArtifact}
         {lineBasedRuntimeErrors}
+        forceLocalUpdates
       />
     {:else if selectedView === "viz"}
       {#if mainError}
@@ -127,6 +128,7 @@
   </MetricsEditorContainer>
 
   <VisualExploreEditing
+    autoSave={selectedView === "viz" || $autoSave}
     slot="inspector"
     exploreResource={exploreResource?.explore}
     {metricsViewName}

diff --git a/web-common/src/features/workspaces/VisualExploreEditing.svelte b/web-common/src/features/workspaces/VisualExploreEditing.svelte
@@ -48,10 +48,12 @@
   export let exploreResource: V1Explore | undefined;
   export let metricsViewName: string | undefined;
   export let viewingDashboard: boolean;
+  export let autoSave: boolean;
   export let switchView: () => void;
 
   $: ({ instanceId } = $runtime);
-  $: ({ localContent, remoteContent, saveContent, path } = fileArtifact);
+  $: ({ localContent, remoteContent, saveContent, path, updateLocalContent } =
+    fileArtifact);
 
   $: exploreSpec = exploreResource?.state?.validSpec;
 
@@ -241,7 +243,11 @@
 
     killState();
 
-    await saveContent(parsedDocument.toString());
+    if (autoSave) {
+      await saveContent(parsedDocument.toString());
+    } else {
+      updateLocalContent(parsedDocument.toString(), true);
+    }
   }
 
   function killState() {
@@ -339,7 +345,9 @@
 
 <Inspector filePath={path}>
   <SidebarWrapper title="Edit dashboard">
-    <p class="text-slate-500 text-sm">Changes below will be auto-saved.</p>
+    {#if autoSave}
+      <p class="text-slate-500 text-sm">Changes below will be auto-saved.</p>
+    {/if}
 
     <Input
       hint="Shown in global header and when deployed to Rill Cloud"