Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lovincyrus committed Dec 23, 2024
1 parent 653d19c commit dea13ae
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
7 changes: 0 additions & 7 deletions web-common/src/features/canvas/CanvasComponent.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,6 @@
$: title = rendererProperties?.title;
$: description = rendererProperties?.description;
// FIXME: already setting staticGrid in CanvasDashboardEmbed
// onMount(async () => {
// if (!embed) {
// gridStackManager.setStatic(true);
// }
// });
</script>

<div
Expand Down
6 changes: 3 additions & 3 deletions web-common/src/features/workspaces/CanvasWorkspace.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import { runtime } from "@rilldata/web-common/runtime-client/runtime-store";
import { parseDocument } from "yaml";
import PreviewButton from "../explores/PreviewButton.svelte";
import { useCanvasStore } from "@rilldata/web-common/features/canvas/stores/canvas-stores";
export let fileArtifact: FileArtifact;
Expand Down Expand Up @@ -80,8 +79,9 @@
$: mainError = lineBasedRuntimeErrors?.at(0);
// Get canvas store
$: canvasEntity = useCanvasStore(canvasName);
// TODO: to be removed
// $: canvasEntity = useCanvasStore(canvasName);
// $: console.log("[CanvasWorkspace] canvasEntity", $canvasEntity?.gridstack);
async function onChangeCallback(newTitle: string) {
const newRoute = await handleEntityRename(
Expand Down

0 comments on commit dea13ae

Please sign in to comment.