Fix: stacked area chart for non string dimension values (#4859)

* Fix: stacked area chart for non string dimension values * Disable lint for regex
rilldata · May 8, 2024 · c1ca7e5 · c1ca7e5 · github-actions · May 8, 2024
1 parent 2438e8f
commit c1ca7e5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/web-common/src/features/charts/templates/build-template.ts b/web-common/src/features/charts/templates/build-template.ts
@@ -24,7 +24,7 @@ export interface ChartField {
   // for custom tooltip field names
   tooltipName?: string;
   // for mapping nominal values to colors
-  values?: (string | null)[];
+  values?: (number | undefined | string | null)[];
 }
 
 export function buildVegaLiteSpec(

diff --git a/web-common/src/features/charts/templates/utils.ts b/web-common/src/features/charts/templates/utils.ts
@@ -22,11 +22,14 @@ export function multiLayerBaseSpec() {
   return baseSpec;
 }
 
-export function sanitizeValueForVega(value: string | null) {
-  return value
-    ? value.replace(/[\.\-\{\}\[\]]/g, (match) => `\\${match}`) //eslint-disable-line
-    : String(value);
+export function sanitizeValueForVega(value: unknown) {
+  if (typeof value === "string") {
+    return value.replace(/[\.\-\{\}\[\]]/g, (match) => `\\${match}`); //eslint-disable-line
+  } else {
+    return String(value);
+  }
 }
-export function sanitizeValuesForSpec(values: (string | null)[]) {
+
+export function sanitizeValuesForSpec(values: unknown[]) {
   return values.map((value) => sanitizeValueForVega(value));
 }