Fix fileartifact reference in component class

rilldata · Dec 20, 2024 · bab44b4 · bab44b4
1 parent edd973d
commit bab44b4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/web-common/src/features/canvas/components/BaseCanvasComponent.ts b/web-common/src/features/canvas/components/BaseCanvasComponent.ts
@@ -42,13 +42,14 @@ export abstract class BaseCanvasComponent<T> implements CanvasComponent<T> {
     const parseDocumentStore = getParsedDocument(this.fileArtifact);
     const parsedDocument = get(parseDocumentStore);
 
-    const { saveContent } = this.fileArtifact;
+    const { updateEditorContent, saveLocalContent } = this.fileArtifact;
 
     // Update the Item
     parsedDocument.setIn(this.pathInYAML, newSpec);
 
     // Save the updated document
-    await saveContent(parsedDocument.toString());
+    updateEditorContent(parsedDocument.toString(), true);
+    await saveLocalContent();
   }
 
   async setSpec(newSpec: T): Promise<void> {

diff --git a/web-common/src/features/canvas/inspector/ComponentInputs.svelte b/web-common/src/features/canvas/inspector/ComponentInputs.svelte
@@ -76,7 +76,6 @@ Handle optional fields and defaults properly
           type={config.type}
           selectedItem={paramValues[key]}
           onSelect={async (field) => {
-            console.log(field);
             component.updateProperty(key, field);
           }}
         />

diff --git a/web-common/src/features/canvas/inspector/PositionalFieldConfig.svelte b/web-common/src/features/canvas/inspector/PositionalFieldConfig.svelte
@@ -25,7 +25,7 @@
     label={`${config.label || key} Field`}
     metricName={metricsView}
     id={`${key}-field`}
-    type="measure"
+    type={key === "x" ? "dimension" : "measure"}
     selectedItem={value?.field || ""}
     onSelect={async (field) => {
       updateFieldConfig("field", field);

diff --git a/web-common/src/features/canvas/inspector/types.ts b/web-common/src/features/canvas/inspector/types.ts
@@ -20,4 +20,5 @@ export interface ComponentInputParam {
   showInUI?: boolean; // If not specified, can assume true
   required?: boolean; // If not specified, can assume true
   description?: string; // Tooltip description for the input
+  meta?: Record<string, string>; // Any additional metadata
 }