Remove measure big num changes

rilldata · Sep 9, 2023 · 9a1798c · 9a1798c
1 parent ef63719
commit 9a1798c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/web-common/src/features/dashboards/big-number/MeasureBigNumber.svelte b/web-common/src/features/dashboards/big-number/MeasureBigNumber.svelte
@@ -1,6 +1,5 @@
 <script lang="ts">
   import { WithTween } from "@rilldata/web-common/components/data-graphic/functional-components";
-  import { metricsExplorerStore } from "@rilldata/web-common/features/dashboards/dashboard-stores";
   import PercentageChange from "@rilldata/web-common/components/data-types/PercentageChange.svelte";
   import CrossIcon from "@rilldata/web-common/components/icons/CrossIcon.svelte";
   import Tooltip from "@rilldata/web-common/components/tooltip/Tooltip.svelte";
@@ -18,8 +17,6 @@
     humanizeDataTypeExpanded,
   } from "../humanize-numbers";
 
-  export let metricViewName: string;
-  export let measureName: string;
   export let value: number;
   export let comparisonOption: TimeComparisonOption = undefined;
   export let comparisonValue: number = undefined;
@@ -43,15 +40,10 @@
 
   /** when the measure is a percentage, we don't show a percentage change. */
   $: measureIsPercentage = formatPresetEnum === FormatPreset.PERCENTAGE;
-
-  function expandMeasure() {
-    metricsExplorerStore.setExpandedMeasureName(metricViewName, measureName);
-  }
 </script>
 
 <button
-  on:click={() => expandMeasure()}
-  class="flex flex-col px-2 py-1 text-left hover:bg-gray-100 {withTimeseries
+  class="flex flex-col px-2 py-1 text-left {withTimeseries
     ? 'my-2'
     : 'justify-between'}"
 >

diff --git a/web-common/src/features/dashboards/big-number/MeasuresContainer.svelte b/web-common/src/features/dashboards/big-number/MeasuresContainer.svelte
@@ -194,8 +194,6 @@
           class="inline-grid"
         >
           <MeasureBigNumber
-            {metricViewName}
-            measureName={measure.name}
             value={bigNum}
             description={measure?.description ||
               measure?.label ||

diff --git a/web-common/src/features/dashboards/time-series/MetricsTimeSeriesCharts.svelte b/web-common/src/features/dashboards/time-series/MetricsTimeSeriesCharts.svelte
@@ -363,8 +363,6 @@
         FormatPreset[measure?.format] || FormatPreset.HUMANIZE}
       <!-- FIXME: I can't select a time series by measure id. -->
       <MeasureBigNumber
-        {metricViewName}
-        measureName={measure.name}
         value={bigNum}
         {showComparison}
         comparisonOption={$timeControlsStore?.selectedComparisonTimeRange?.name}