fix panic (#5388)

rilldata · Aug 5, 2024 · 92ab0cc · 92ab0cc
1 parent 96be6fc
commit 92ab0cc
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/runtime/reconcilers/model.go b/runtime/reconcilers/model.go
@@ -1220,6 +1220,13 @@ func (r *ModelReconciler) acquireExecutor(ctx context.Context, self *runtimev1.R
 		return nil, nil, err
 	}
 
+	// Acquire the final result manager
+	finalResultManager, ok := finalOpts.OutputHandle.AsModelManager(r.C.InstanceID)
+	if !ok {
+		finalRelease()
+		return nil, nil, fmt.Errorf("output connector %q is not capable of managing model results", mdl.Spec.OutputConnector)
+	}
+
 	// Wrap the executors
 	wrapped := &wrappedModelExecutor{
 		finalConnector:     finalConnector,
@@ -1229,6 +1236,7 @@ func (r *ModelReconciler) acquireExecutor(ctx context.Context, self *runtimev1.R
 		stage:              stage,
 		stageOpts:          stageOpts,
 		stageResultManager: stageResultManager,
+		finalResultManager: finalResultManager,
 	}
 	release := func() {
 		stageRelease()