Fix "Select all" buttons (#6209)

rilldata · Dec 5, 2024 · 908f1ff · 908f1ff · github-actions · Dec 5, 2024
1 parent 0740f14
commit 908f1ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/web-common/src/features/dashboards/dimension-table/DimensionHeader.svelte b/web-common/src/features/dashboards/dimension-table/DimensionHeader.svelte
@@ -168,7 +168,10 @@
   <!-- We fix the height to avoid a layout shift when the Search component is expanded. -->
   <div class="flex items-center gap-x-1 cursor-pointer h-9">
     {#if !isRowsEmpty}
-      <SelectAllButton {areAllTableRowsSelected} on:toggle-all-search-items />
+      <SelectAllButton
+        {areAllTableRowsSelected}
+        on:toggle-all-search-items={onToggleSearchItems}
+      />
     {/if}
     {#if searchBarOpen || (searchText && searchText !== "")}
       <div

diff --git a/web-common/src/features/dashboards/time-dimension-details/TDDHeader.svelte b/web-common/src/features/dashboards/time-dimension-details/TDDHeader.svelte
@@ -207,7 +207,10 @@
   {#if comparing === "dimension"}
     <div class="flex items-center mr-4 gap-x-3" style:cursor="pointer">
       {#if !isRowsEmpty}
-        <SelectAllButton {areAllTableRowsSelected} on:toggle-all-search-items />
+        <SelectAllButton
+          {areAllTableRowsSelected}
+          on:toggle-all-search-items={onToggleSearchItems}
+        />
       {/if}
 
       {#if !searchToggle}