Self review

rilldata · Sep 12, 2023 · 8fb5b66 · 8fb5b66
1 parent a3b249e
commit 8fb5b66
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/runtime/drivers/bigquery/bigquery.go b/runtime/drivers/bigquery/bigquery.go
@@ -213,6 +213,9 @@ func parseSourceProperties(props map[string]any) (*sourceProperties, error) {
 	if err != nil {
 		return nil, err
 	}
+	if conf.SQL == "" {
+		return nil, fmt.Errorf("property 'sql' is mandatory for connector \"bigquery\"")
+	}
 	if conf.ProjectID == "" {
 		conf.ProjectID = bigquery.DetectProjectID
 	}

diff --git a/runtime/drivers/duckdb/transporter/motherduck_to_duckDB.go b/runtime/drivers/duckdb/transporter/motherduck_to_duckDB.go
@@ -114,7 +114,7 @@ func (t *motherduckToDuckDB) Transfer(ctx context.Context, srcProps, sinkProps m
 		}
 
 		if srcCfg.SQL == "" {
-			return fmt.Errorf("property \"query\" is mandatory for connector \"motherduck\"")
+			return fmt.Errorf("property \"sql\" is mandatory for connector \"motherduck\"")
 		}
 
 		userQuery := strings.TrimSpace(srcCfg.SQL)

diff --git a/runtime/drivers/duckdb/transporter/utils.go b/runtime/drivers/duckdb/transporter/utils.go
@@ -10,7 +10,7 @@ import (
 )
 
 type sourceProperties struct {
-	Database string `mapstructure:"database"`
+	Database string `mapstructure:"db"`
 	SQL      string `mapstructure:"sql"`
 }
 
@@ -19,6 +19,9 @@ func parseSourceProperties(props map[string]any) (*sourceProperties, error) {
 	if err := mapstructure.Decode(props, cfg); err != nil {
 		return nil, fmt.Errorf("failed to parse source properties: %w", err)
 	}
+	if cfg.SQL == "" {
+		return nil, fmt.Errorf("property 'sql' is mandatory")
+	}
 	return cfg, nil
 }