Fix export not honouring the old filter (#3872)

* Fix old export

* Fix lint

(cherry picked from commit 4f2caf7)

runtime/queries/metricsview_comparison_toplist.go

@@ -845,6 +845,14 @@ func (q *MetricsViewComparison) Export(ctx context.Context, rt *runtime.Runtime,
 	switch olap.Dialect() {
 	case drivers.DialectDuckDB:
 		if opts.Format == runtimev1.ExportFormat_EXPORT_FORMAT_CSV || opts.Format == runtimev1.ExportFormat_EXPORT_FORMAT_PARQUET {
+			// temporary backwards compatibility
+			if q.Filter != nil {
+				if q.Where != nil {
+					return fmt.Errorf("both filter and where is provided")
+				}
+				q.Where = convertFilterToExpression(q.Filter)
+			}
+
 			var sql string
 			var args []any
 			if !isTimeRangeNil(q.ComparisonTimeRange) {

runtime/queries/metricsview_rows.go

@@ -125,6 +125,14 @@ func (q *MetricsViewRows) Export(ctx context.Context, rt *runtime.Runtime, insta
 				return fmt.Errorf("metrics view '%s' does not have a time dimension", q.MetricsViewName)
 			}
 
+			// temporary backwards compatibility
+			if q.Filter != nil {
+				if q.Where != nil {
+					return fmt.Errorf("both filter and where is provided")
+				}
+				q.Where = convertFilterToExpression(q.Filter)
+			}
+
 			timeRollupColumnName, err := q.resolveTimeRollupColumnName(ctx, olap, instanceID, opts.Priority, q.MetricsView)
 			if err != nil {
 				return err

runtime/server/downloads.go

@@ -233,6 +233,7 @@ func (s *Server) downloadHandler(w http.ResponseWriter, req *http.Request) {
 			MetricsViewName:    r.MetricsViewName,
 			TimeStart:          r.TimeStart,
 			TimeEnd:            r.TimeEnd,
+			Filter:             r.Filter,
 			Where:              r.Where,
 			Sort:               r.Sort,
 			Limit:              limitPtr,
@@ -307,6 +308,7 @@ func (s *Server) downloadHandler(w http.ResponseWriter, req *http.Request) {
 			Limit:               s.resolveExportLimit(request.Limit, r.Limit),
 			Offset:              r.Offset,
 			Sort:                r.Sort,
+			Filter:              r.Filter,
 			Where:               r.Where,
 			Having:              r.Having,
 			MetricsView:         mv,