Fix ui tests

rilldata · Sep 9, 2023 · 5c45bd5 · 5c45bd5
1 parent 05c0b26
commit 5c45bd5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/web-common/src/features/dashboards/time-controls/ComparisonSelector.svelte b/web-common/src/features/dashboards/time-controls/ComparisonSelector.svelte
@@ -81,7 +81,7 @@ This component needs to do the following:
     slot="floating-element"
     on:escape={toggleFloatingElement}
     on:click-outside={toggleFloatingElement}
-    label="Time comparison selector"
+    label="Comparison selector"
   >
     <MenuItem
       selected={!(showTimeComparison || selectedDimension)}

diff --git a/web-local/test/ui/dashboards.spec.ts b/web-local/test/ui/dashboards.spec.ts
@@ -173,22 +173,20 @@ test.describe("dashboard", () => {
     expect(parquetRegex.test(downloadParquet.suggestedFilename())).toBe(true);
 
     // Turn off comparison
+    await page.getByRole("button", { name: "Comparing by Time" }).click();
     await page
-      .getByRole("button", { name: "Comparing to last period" })
-      .click();
-    await page
-      .getByLabel("Time comparison selector")
-      .getByRole("menuitem", { name: "no comparison" })
+      .getByLabel("Comparison selector")
+      .getByRole("menuitem", { name: "No comparison" })
       .click();
 
     // Check number
     await expect(page.getByText("272", { exact: true })).toBeVisible();
 
     // Add comparison back
-    await page.getByRole("button", { name: "no comparison" }).click();
+    await page.getByRole("button", { name: "No comparison" }).click();
     await page
-      .getByLabel("Time comparison selector")
-      .getByRole("menuitem", { name: "last period" })
+      .getByLabel("Comparison selector")
+      .getByRole("menuitem", { name: "Time" })
       .click();
 
     /*
@@ -202,7 +200,7 @@ test.describe("dashboard", () => {
 
       For now, we will wait for the menu to disappear before clicking the next menu
      */
-    await expect(page.getByLabel("Time comparison selector")).not.toBeVisible();
+    await expect(page.getByLabel("Comparison selector")).not.toBeVisible();
 
     // Switch to a custom time range
     await interactWithTimeRangeMenu(page, async () => {