Skip to content

Commit

Permalink
Fix dashboards without timestamp and home bookmark
Browse files Browse the repository at this point in the history
  • Loading branch information
AdityaHegde committed Dec 20, 2024
1 parent bd9e09b commit 595fc88
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@
}
prevUrl = redirectUrl.toString();
// using `replaceState` directly messes up the navigation entries,
// `from` and `to` have the old url before being replaced in `afterNavigate` calls leading to incorrect handling.
void goto(redirectUrl, {
replaceState: true,
state: $page.state,
Expand Down Expand Up @@ -194,7 +196,11 @@
};
}
await waitUntil(() => !timeRangeSummaryIsLoading);
// time range summary query has `enabled` based on `metricsSpec.timeDimension`
// isLoading will never be true when the query is disabled, so we need this check before waiting for it.
if (metricsSpec.timeDimension) {
await waitUntil(() => !timeRangeSummaryIsLoading);
}
metricsExplorerStore.init(exploreName, initState);
timeControlsState ??= getTimeControlState(
metricsSpec,
Expand Down

0 comments on commit 595fc88

Please sign in to comment.