Fix timeranges with invalid comparison

rilldata · Dec 17, 2024 · 33a0ac9 · 33a0ac9
1 parent 6e127c9
commit 33a0ac9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/web-admin/src/routes/[organization]/[project]/explore/[dashboard]/+page.svelte b/web-admin/src/routes/[organization]/[project]/explore/[dashboard]/+page.svelte
@@ -29,10 +29,11 @@
     exploreName,
   } = data);
   $: if (errors?.length) {
+    const _errs = errors;
     setTimeout(() => {
       eventBus.emit("notification", {
         type: "error",
-        message: errors[0].message,
+        message: _errs[0].message,
         options: {
           persisted: true,
         },

diff --git a/web-common/src/features/dashboards/url-state/convertURLToExplorePreset.ts b/web-common/src/features/dashboards/url-state/convertURLToExplorePreset.ts
@@ -274,6 +274,8 @@ function fromTimeRangesParams(
       preset.compareTimeRange = ctr;
       preset.comparisonMode ??=
         V1ExploreComparisonMode.EXPLORE_COMPARISON_MODE_TIME;
+    } else if (ctr == "") {
+      preset.compareTimeRange = "";
     } else {
       errors.push(getSingleFieldError("compare time range", ctr));
     }

diff --git a/web-local/src/routes/(viz)/explore/[name]/+page.svelte b/web-local/src/routes/(viz)/explore/[name]/+page.svelte
@@ -25,10 +25,11 @@
     exploreName,
   } = data);
   $: if (errors?.length) {
+    const _errs = errors;
     setTimeout(() => {
       eventBus.emit("notification", {
         type: "error",
-        message: errors[0].message,
+        message: _errs[0].message,
         options: {
           persisted: true,
         },