Fix test connector acquire

runtime/drivers/clickhouse/clickhouse.go

@@ -189,6 +189,8 @@ func (d driver) Open(instanceID string, config map[string]any, st *storage.Clien
 		if err != nil {
 			return nil, err
 		}
+	} else {
+		return nil, errors.New("no clickhouse connection configured: 'dsn', 'host' or 'managed: true' must be set")
 	}
 
 	db := sqlx.NewDb(otelsql.OpenDB(clickhouse.Connector(opts)), "clickhouse")

runtime/metricsview/executor_validate_test.go

@@ -60,6 +60,7 @@ select parseDateTimeBestEffort('2024-01-05T00:00:00Z') as time, 'DK' as country,
 `,
 		},
 	})
+	testruntime.RequireReconcileState(t, rt, instanceID, 2, 0, 0)
 
 	// Test cases of metrics view YAML partials defining dimensions and measures.
 	cases := []struct {

runtime/testruntime/connectors.go

@@ -3,6 +3,7 @@ package testruntime
 import (
 	"context"
 	"fmt"
+	"log"
 	"os"
 	"path/filepath"
 	goruntime "runtime"
@@ -64,6 +65,7 @@ var Connectors = map[string]ConnectorAcquireFunc{
 		require.NoError(t, err)
 
 		t.Cleanup(func() {
+			log.Printf("TERMINATING")
 			err := clickHouseContainer.Terminate(ctx)
 			require.NoError(t, err)
 		})

runtime/testruntime/testruntime.go

@@ -108,8 +108,13 @@ func NewInstanceWithOptions(t TestingT, opts InstanceOptions) (*runtime.Runtime,
 	vars["rill.stage_changes"] = strconv.FormatBool(opts.StageChanges)
 
 	for _, conn := range opts.TestConnectors {
-		connVars := Connectors[conn](t)
-		maps.Copy(vars, connVars)
+		acquire, ok := Connectors[conn]
+		require.True(t, ok, "unknown test connector %q", conn)
+		cfg := acquire(t)
+		for k, v := range cfg {
+			k = fmt.Sprintf("connector.%s.%s", conn, k)
+			vars[k] = v
+		}
 	}
 
 	tmpDir := t.TempDir()