Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Modernization #57

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
build
release
lib/charLS-DynamicMemory-browser.js
25 changes: 25 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
module.exports = {
env: {
browser: true,
jest: true
},
root: true,
ignorePatterns: ['dist/**/*'],
extends: ['standard', 'plugin:prettier/recommended'],
plugins: ['prettier'],
rules: {
'no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
camelcase: 'off',
'import/order': 'error',
'prettier/prettier': [
'error',
{
tabWidth: 2,
printWidth: 120,
singleQuote: true,
trailingComma: 'none',
semi: false
}
]
}
}
7 changes: 3 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ jobs:
cache: "npm"
- run: npm install
- run: npm run build
# TODO: activate this once a linting setup exists
# - name: Lint
# if: matrix.os != 'windows-latest'
# run: npm run lint
- name: Lint
if: matrix.os != 'windows-latest'
run: npm run lint
- run: npm run test
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ var series = new daikon.Series();
var files = fs.readdirSync('./data/volume/');

// iterate over files
for (var ctr in files) {
for (let ctr in files) {
var name = './data/volume/' + files[ctr];
var buf = fs.readFileSync(name);

Expand Down
64 changes: 0 additions & 64 deletions lib/charLS-DynamicMemory-browser.js

This file was deleted.

Loading