Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added response logging including status code #45

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

seckek
Copy link

@seckek seckek commented Aug 9, 2021

Implemented response logging which includes the status code and the raw response. This was done by processing the request when messageIsRequest is false in order to get the response / status info.

@righettod
Copy link
Owner

Hi, Thanks you very (x10000000) much for the PR 🥇

I will take a look at it quickly (i'm little busy currently).

I think I will add an option to enabled/disable the logging of the response, test it on real assessment to ensure that the extension did not break burp then release this as the 2.0.0 as it change the initial behavior of the extension 😃

Thanks again 👍

@righettod righettod self-assigned this Aug 11, 2021
@righettod righettod added the enhancement New feature or request label Aug 11, 2021
@righettod righettod linked an issue Aug 11, 2021 that may be closed by this pull request
@seckek
Copy link
Author

seckek commented Aug 11, 2021

Hey, thanks for having a look and for making the extension! Enabling/disabling the logging of the response sounds good - I wasn't sure how it would work with the extra columns so I left it without it for now but I think it is doable (maybe by altering the table to add 2 extra columns once logging of responses is included).

@righettod
Copy link
Owner

I will manage it 😃
I will keep you informed. I must just find a slot to work on this point 😄

@righettod righettod merged commit e0f5606 into righettod:master Aug 12, 2021
@righettod righettod mentioned this pull request Aug 13, 2021
4 tasks
@righettod
Copy link
Owner

@seckek : I have merged the PR so, from now, all night build will contains your feature 👍

I have also create this issue for me to track the release 2.0.0: #47

@righettod
Copy link
Owner

@seckek Hi, I finally manage to find time to start the release process, I'm working with PortSwigger to release the extension on the store...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Could you add an option to log the response too?
2 participants