Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem version to 0.4.8 #98

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Update gem version to 0.4.8 #98

merged 1 commit into from
Jan 1, 2025

Conversation

tanvincible
Copy link
Collaborator

PR Description:

This PR updates the no-style-please theme to maintain compatibility with the latest versions of its dependencies. The changes made in this PR are as follows:

  1. Ruby 3.4.1 (Stable):

    • Updated the Gemfile to include the following dependencies required by Ruby 3.4.1:
      • gem "csv"
      • gem "bigdecimal"
      • gem "base64"
      • gem "logger"
    • csv, bigdecimal, base64 were loaded from the standard library, but are not part of the default gems starting from Ruby 3.4.0.
    • logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
  2. Jekyll Version:

    • Updated jekyll version to 3.10.0 to ensure compatibility with GitHub Pages.
  3. Jekyll Feed:

    • Updated jekyll-feed to 0.17.0 to remain in sync with the latest stable release of the plugin.
  4. SCSS Updates:

    • The SCSS files have been updated to replace the deprecated @import rule with the newer @use rule.
    • This change ensures the theme follows the latest best practices for SCSS, but it does result in the need to manually compile the SCSS to CSS. Consequently, the CSS file size has increased slightly from 1KB (when using @import) to accommodate the changes introduced by @use.
  5. Bug Fixes:

@tanvincible tanvincible added the enhancement New feature or request label Dec 28, 2024
@tanvincible tanvincible requested a review from riggraz December 28, 2024 15:20
Copy link
Owner

@riggraz riggraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@tanvincible tanvincible merged commit 48c13ee into master Jan 1, 2025
@tanvincible tanvincible deleted the patch-3 branch January 1, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use no-style-please on Jekyll above 3.8.7
2 participants