Dev/1.5.0 #47
Merged
Dev/1.5.0 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iOS is dummy implementation
…at/write-file-protcol
* [kmm, RN] add limitless interval shooting. * Change capture mode when transitioned to capture * [flutter] add limitless interval shooting. * done feedback from detekt. changed detekt config for SDK. * [kmm, RN, flutter] limitless interval shooting: 1. changed result from string to String List. 2. add setCaptureInterval. 3. changed settings for different camera model. * [kmm]changed LimitlessIntervalCapture's builder. * [kmm] get fileUrl for SC2 of limitless interval shooting. * [kmm]changed getting fileUrl for SC2. [flutter]fixed test. * [kmm] limitless interval: removed getState for sc2. * Fix cancel to LimitlessIntervalCapture * Add LimitlessIntervalCapture test * Fix capture cancel test * Fix LimitlessIntervalCapture to flutter --------- Co-authored-by: osakila <[email protected]>
Implement firmware update function
* add options _topBottomCorrection and _topBottomCorrectionRotation. * add _topBottomCorrectionRotation ui to verification-tool. * [kmm] fixed OptionsTest.
…tching, and VisibilityReduction for Flutter
* add interval shooting with the shot count specified. * fixed comments. * fixed the feedback. * [RN] fixed verification-tool new screen. * [private] changed RN's Android bridge. * [RN] changed Android bridge. * fixed feedbacks by detekt. * fixed feedback. * delete semicolon from kotlin * fixed option-name mistake. * delete unused import. * add canceled flow to PhotoCapture, time-shift, ShotCountSpecifiedIntervalCapture * Fix stop error * Move constant to companion object * Improve canceled shooting * Fix PhotoCapture * Fix TimeShiftCapture * Fix cancel PhotoCapture for SC2 * Fix ShotCountSpecifiedIntervalCaptureTest * Add cancel takePicture test * Add cancel TimeShiftCapture test * Add stop error test to ShotCountSpecifiedIntervalCapture * Add stop error test to ShotCountSpecifiedIntervalCapture --------- Co-authored-by: osakila <[email protected]>
* update version to 1.5.0 * format code use androidStudio and swiftformat
ywatanabe-dev
approved these changes
Oct 23, 2023
osakila
approved these changes
Oct 23, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...iplatform/src/commonMain/kotlin/com/ricoh360/thetaclient/capture/LimitlessIntervalCapture.kt
Show resolved
Hide resolved
...iplatform/src/commonMain/kotlin/com/ricoh360/thetaclient/capture/LimitlessIntervalCapture.kt
Show resolved
Hide resolved
...iplatform/src/commonMain/kotlin/com/ricoh360/thetaclient/capture/LimitlessIntervalCapture.kt
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/ricoh360/thetaclient/capture/ShotCountSpecifiedIntervalCapture.kt
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/ricoh360/thetaclient/capture/ShotCountSpecifiedIntervalCapture.kt
Show resolved
Hide resolved
react-native/android/src/main/java/com/ricoh360/thetaclientreactnative/Converter.kt
Show resolved
Hide resolved
react-native/android/src/main/java/com/ricoh360/thetaclientreactnative/Converter.kt
Show resolved
Hide resolved
react-native/android/src/main/java/com/ricoh360/thetaclientreactnative/Converter.kt
Show resolved
Hide resolved
react-native/android/src/main/java/com/ricoh360/thetaclientreactnative/Converter.kt
Show resolved
Hide resolved
react-native/android/src/main/java/com/ricoh360/thetaclientreactnative/Converter.kt
Show resolved
Hide resolved
| * read a byte with chunk processing | ||
| */ | ||
| @Suppress("CognitiveComplexMethod", "CyclomaticComplexMethod", "NestedBlockDepth", "LoopWithTooManyJumpStatements") | ||
| private suspend fun readByte(): Byte? { |
There was a problem hiding this comment.
| The function readByte appears to be too complex (21). Defined complexity threshold for methods is set to '20' |
simago
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.5.0