Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround limitation with pipenv action #37

Merged
merged 3 commits into from
Apr 28, 2024
Merged

Workaround limitation with pipenv action #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60f2a90
Workaround limitation with pipenv action
ricobl Apr 28, 2024
2df63a7
Fix test workflow format
ricobl Apr 28, 2024
c300707
Fix bytes / string comparison in test
ricobl Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,14 @@ jobs:
- name: Display Python version
run: python -c "import sys; print(sys.version)"

- name: Install dependecies
uses: VaultVulp/[email protected]
with:
command: install --dev
- name: Install pipenv
run: pip install --user pipenv

- name: Install all dependencies, including development ones
run: pipenv sync --dev

- name: Install Django
run: pip install -q Django~=${{ matrix.django-version }}

- name: Test
uses: VaultVulp/[email protected]
with:
command: run test
run: pipenv run test
5 changes: 3 additions & 2 deletions testproject/tests/test_crypto_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
class TestCryptoInstance(TestCase):

def test_should_have_a_default_secret_key(self):
self.assertEqual(crypto.key, 'MY_SECURE_KEY')
self.assertEqual(crypto.key, conf.THUMBOR_SECURITY_KEY)
key = crypto.key.decode('utf-8')
self.assertEqual(key, 'MY_SECURE_KEY')
self.assertEqual(key, conf.THUMBOR_SECURITY_KEY)

@override_settings(THUMBOR_SECURITY_KEY='custom-security-key')
def test_should_read_key_from_settings(self):
Expand Down
Loading