Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension namespace fix to be PSR-4 compatible after monorepo merge #25

Merged

Conversation

ek9
Copy link
Contributor

@ek9 ek9 commented Feb 2, 2017

This is a big PR with the following changes:

  • The namespaces have been updated to be compatible with PSR-4 and reflect the updated structure after everything has been moved to monorepo. This mostly means that everything is under RMiller\BehatSpec now (src/), thus src/Extension becomes RMiller\BehatSpec\Extension. This was a bigger change, but I have updated all the related composer.json files + tests + retested everything to make sure all of the extensions work fine.
  • PHPSpec related extension requirements updated PHP requirement from 5.4+ to 5.6+ (phpspec3 requires 5.6+)
  • Update composer.json of behat-spec package to efficiently and correctly load extension via PSR-4
  • Updated README.md to ask using v0.3.* for PHPSpec2 support until v0.4.* is stable.
  • Updated README.md in main and all extensions to use the new namespaces

This is related to and fixes #18 #23

I have made sure all the tests pass in all extensions where the tests were setup. There is still ExemplifyExtension tests failing, but it's same failures that were there before this PR (I've made a sparate issue to track it)

ek9 added 21 commits February 2, 2017 02:31
…iller\BehatSpec\Extension\ErrorExtension for PSR-4 compatibility
@ek9
Copy link
Contributor Author

ek9 commented Feb 2, 2017

I belive src/Extension directory is setup as part of subtreesplit. I would suggest to get rid of that instead and use src/<EXTENSION> structure. We could then also remove the Extension sub-namespace to clean it up, however that would require further updates to subtreesplit + break compatibility with 0.4

@ek9
Copy link
Contributor Author

ek9 commented Feb 2, 2017

This would fix #25

@ek9
Copy link
Contributor Author

ek9 commented Feb 2, 2017

This would also fix #5 as I have tried running the updated version on an existing behat/phpspec heavy project which previously relied on phpspec2 and it seems to work fine with PHPSpec3 so far.

@richardmiller-zz richardmiller-zz merged commit 916f6e8 into richardmiller-zz:master Feb 16, 2017
@richardmiller-zz
Copy link
Owner

Brilliant, thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of Behat and PhpSpec extensions
2 participants