-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension namespace fix to be PSR-4 compatible after monorepo merge #25
Extension namespace fix to be PSR-4 compatible after monorepo merge #25
Conversation
…iller\BehatSpec\Extension\ErrorExtension for PSR-4 compatibility
…ion namespace for PSR-4
…ec2 + PHP 5.6+ for phpspec3
I belive |
This would fix #25 |
This would also fix #5 as I have tried running the updated version on an existing behat/phpspec heavy project which previously relied on phpspec2 and it seems to work fine with PHPSpec3 so far. |
Brilliant, thank you for this! |
This is a big PR with the following changes:
RMiller\BehatSpec
now (src/
), thussrc/Extension
becomesRMiller\BehatSpec\Extension
. This was a bigger change, but I have updated all the related composer.json files + tests + retested everything to make sure all of the extensions work fine.composer.json
ofbehat-spec
package to efficiently and correctly load extension viaPSR-4
v0.3.*
for PHPSpec2 support untilv0.4.*
is stable.This is related to and fixes #18 #23
I have made sure all the tests pass in all extensions where the tests were setup. There is still ExemplifyExtension tests failing, but it's same failures that were there before this PR (I've made a sparate issue to track it)