Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load configuration file if it exists #122

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Load configuration file if it exists #122

merged 2 commits into from
Mar 11, 2021

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Mar 10, 2021

If config/attr_masker.rb exists, then it is loaded from a Rake task. Fixes #118.

spec/features/shared_examples.rb Show resolved Hide resolved
spec/unit/rake_task_spec.rb Show resolved Hide resolved
spec/unit/rake_task_spec.rb Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #122 (7cbb227) into master (5bc7741) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   99.46%   99.48%   +0.02%     
==========================================
  Files          24       26       +2     
  Lines         371      388      +17     
==========================================
+ Hits          369      386      +17     
  Misses          2        2              
Impacted Files Coverage Δ
lib/tasks/db.rake 90.90% <100.00%> (+2.02%) ⬆️
spec/dummy/config/attr_masker.rb 100.00% <100.00%> (ø)
spec/support/force_config_file_reload.rb 100.00% <100.00%> (ø)
spec/unit/rake_task_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc7741...7d98b40. Read the comment docs.

@skalee
Copy link
Contributor Author

skalee commented Mar 10, 2021

Converting to draft. I forgot to update docs.

@skalee skalee marked this pull request as draft March 10, 2021 18:08
@skalee skalee marked this pull request as ready for review March 11, 2021 06:21
@skalee skalee merged commit 30a4a1e into master Mar 11, 2021
@skalee skalee deleted the config-file branch March 11, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for global config file
1 participant