Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing matcher param to get recording rule blocks and adding compaction level max to avoid copying non-compacted blocks (for-now). #713

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

moadz
Copy link
Contributor

@moadz moadz commented Dec 25, 2024

  • Removing matcher param to make sure we pick up the non-tenanted recording rule blocks
  • Setting min-compaction to 3 to avoid copying blocks that later have to be re-compacted/duplicated over time (e.g. we copy the raw blocks from receivers, in two hours we also copy the compacted blocks by telemeter compaction and we have to double-compact)

After this - I'll raise a PR to repoint to the telemeter-lts bucket (>120Gi of DH metrics), then I will repoint the rhobs namespace thanos compactor to that bucket as well so we can monitor compaction.

…ying non-compacted blocks (for-now).

Signed-off-by: Moad Zardab <[email protected]>
@moadz moadz requested a review from philipgough December 25, 2024 19:12
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@moadz moadz merged commit dbafd28 into rhobs:main Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants