Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compactor concurrency flags #710

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Adding compactor concurrency flags #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jsonnetfile.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
"subdir": "configuration"
}
},
"version": "e743a6abc673774e60bf37b94e6454e542db46f0",
"version": "e59b139d57c7d5f60dbc43c061257d5139032e4b",
"sum": "AuUPEXXfd/hxMbKWdURRKaCTBPcTJD4cs9XApBIZbiA="
},
{
Expand Down
6 changes: 6 additions & 0 deletions resources/services/observatorium-metrics-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ objects:
- --downsample.concurrency=1
- --deduplication.replica-label=replica
- --debug.max-compaction-level=3
- --compact.concurrency=${THANOS_COMPACTOR_COMPACT_CONCURRENCY}
- --downsample.concurrency=${THANOS_COMPACTOR_DOWNSAMPLE_CONCURRENCY}
- ${THANOS_COMPACTOR_RETENTION_DISABLE_DOWNSAMPLING}
env:
- name: OBJSTORE_CONFIG
Expand Down Expand Up @@ -4453,6 +4455,10 @@ parameters:
value: 50Gi
- name: THANOS_COMPACTOR_REPLICAS
value: "1"
- name: THANOS_COMPACTOR_COMPACT_CONCURRENCY
value: "1"
- name: THANOS_COMPACTOR_DOWNSAMPLE_CONCURRENCY
value: "1"
- name: THANOS_CONFIG_SECRET
value: thanos-objectstorage
- name: THANOS_IMAGE_TAG
Expand Down
6 changes: 5 additions & 1 deletion services/observatorium-metrics-template-overwrites.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,11 @@ local thanosRuleSyncer = import './sidecars/thanos-rule-syncer.libsonnet';
// Temporary workaround on high cardinality blocks for 2w.
// Since we have only 2w retention, there is no point in having 2w blocks.
// See: https://issues.redhat.com/browse/OBS-437
args+: ['--debug.max-compaction-level=3'] + disableDownsamplingFlag,
args+: [
'--debug.max-compaction-level=3',
'--compact.concurrency=${THANOS_COMPACTOR_COMPACT_CONCURRENCY}',
'--downsample.concurrency=${THANOS_COMPACTOR_DOWNSAMPLE_CONCURRENCY}',
] + disableDownsamplingFlag,
} else c
for c in super.containers
],
Expand Down
2 changes: 2 additions & 0 deletions services/observatorium-metrics-template.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ local obs = import 'observatorium.libsonnet';
{ name: 'THANOS_COMPACTOR_MEMORY_REQUEST', value: '1Gi' },
{ name: 'THANOS_COMPACTOR_PVC_REQUEST', value: '50Gi' },
{ name: 'THANOS_COMPACTOR_REPLICAS', value: '1' },
{ name: 'THANOS_COMPACTOR_COMPACT_CONCURRENCY', value: '1' },
{ name: 'THANOS_COMPACTOR_DOWNSAMPLE_CONCURRENCY', value: '1' },
{ name: 'THANOS_CONFIG_SECRET', value: 'thanos-objectstorage' },
{ name: 'THANOS_IMAGE_TAG', value: 'v0.36.0' },
{ name: 'THANOS_IMAGE', value: 'quay.io/thanos/thanos' },
Expand Down
Loading