Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create go configuration rhobs #602

Merged
merged 32 commits into from
Oct 9, 2023
Merged

Create go configuration rhobs #602

merged 32 commits into from
Oct 9, 2023

Conversation

thibaultmg
Copy link
Contributor

No description provided.

saswatamcode
saswatamcode reviewed Sep 21, 2023
View reviewed changes
mimic.go Outdated Show resolved Hide resolved
@thibaultmg
init service_go
843a8d1 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
wip
4447792 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
add post processing
16af0ee 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
add store template
55933ca 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
add replicas in instance config
87e0de7 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
update generated files
0960047 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
change dir of generated tamplates
3232889 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
update go.mod
68a5f86 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
remove store cache
b205079 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg thibaultmg force-pushed the create_go_configuration_rhobs branch from 7cb7770 to b205079 Compare September 27, 2023 12:16
@thibaultmg
add some comments
2953d15 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg thibaultmg marked this pull request as ready for review September 27, 2023 12:30
douglascamata
douglascamata reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update this to reflect the fact that we're running Tempo now instead of Jaeger, right @philipgough?

Also left some questions.

resources/services/app-sre-stage-01/rhobs/observatorium-metrics-store-template.yaml Outdated Show resolved Hide resolved
services_go/observatorium/observatorium.go Outdated Show resolved Hide resolved
@thibaultmg
remove post process
dd0b441 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg thibaultmg changed the title WIP: Create go configuration rhobs Create go configuration rhobs Sep 28, 2023
@thibaultmg
remove status section from yaml
7d229f7 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
fix anti affinity namespace
68d1289 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
update tracing sidecar reporter host
e211a99 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
add preManifests hooks
5b4510f 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
update store sharding
ee9c319 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
add pdb
1276848 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
set oauth proxy secret as param
a34478a 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
fix type meta
09f7b64 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
remove oauth secret
73a6ce4 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
remove cookie file config in oauth proxy
9725b92 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
upgrade observatorium dep for fixes
27e2a59 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
improve objstore config management
64d7e9d 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
add route for compactor ui
4398ae8 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
fix
e62acfc 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
upgrade go ci image
81fbaff 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
go mod tidy
9eda975 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
upgrade go ci
7e42b25 
Signed-off-by: Thibault Mange <[email protected]>
douglascamata
douglascamata approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
moadz
moadz reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@moadz moadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Just a few changes we ned to look at.

services_go/instances/rhobs/rhobs.go Outdated Show resolved Hide resolved
services_go/instances/rhobs/rhobs.go Outdated Show resolved Hide resolved
resources/services/app-sre-stage-01/rhobs/observatorium-metrics-compact-telemeter-template.yaml Outdated Show resolved Hide resolved
@thibaultmg thibaultmg merged commit 702bbe7 into rhobs:main Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode left review comments

@moadz moadz moadz left review comments

@philipgough philipgough philipgough left review comments

@douglascamata douglascamata douglascamata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thibaultmg @douglascamata @philipgough @moadz @saswatamcode