Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build coreOS with kdump RPM and run tests #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbtrystram
Copy link

@jbtrystram jbtrystram commented Dec 13, 2024

This will uses Fedora CoreOS jenkins instance to run tests on PRs for this repo. It simply uses packit to create an RPM and build an FCOS VM image with it, then run some kdump tests.

Example of a run : https://jenkins-coreos-ci.apps.ocp.fedoraproject.org/blue/organizations/jenkins/kdump-upstream/detail/enable-coreos-ci/5/pipeline

Here are the tests being run :

Note that you need to be a members of coreos or openshift orgs to cancel or restart jobs. Maybe we need to work a better way around that.

A couple items needs to be done to fully complete this :

  • add github user coreosbot as an admin to this repo : enable github hooks to report the results on PRs
  • Merge this PR to enable it on upstream CI

See there for more details.

Also see https://issues.redhat.com/browse/RHEL-70438

jbtrystram added a commit to jbtrystram/coreos-ci that referenced this pull request Dec 13, 2024
In an effort to reduce kdump issues, let's run our tests against their
upstream repo, to catch problems earlier.

See rhkdump/kdump-utils#62
Also: https://issues.redhat.com/browse/RHEL-70438
.cci.jenkinsfile Outdated Show resolved Hide resolved
mv x86_64/kdump-utils*coreos.tests*.rpm ./kdump-coreos-ci.rpm
""")
}
stash includes: 'kdump-coreos-ci.rpm', name: 'kdump-rpm'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also useful to archive the RPMs so that anyone can also download them and test them locally. This has come in quite handy a few times in rpm-ostree:

https://github.com/coreos/rpm-ostree/blob/94b701f1bcc4ae9067a5dc350e43e28f20459ac7/.cci.jenkinsfile#L15-L16

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea !

Comment on lines +31 to +38
shwrap("""
coreos-assembler init --force https://github.com/coreos/fedora-coreos-config
mv kdump-coreos-ci.rpm overrides/rpm
cosa fetch --with-cosa-overrides
cosa build
""")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, though honestly we should probably add a e.g. rpms argument to cosaBuild so all this becomes cosaBuild(rpms: ['kdump-rpm']). Similar to the overlays dir.

Copy link
Author

@jbtrystram jbtrystram Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion. I don't know all the features of coreos-ci-lib (yet) 😃
edit: oh it was an improvement suggestion, I got confused !

}

// the kdump kola tests
stage("Kola kdump tests") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just

Suggested change
stage("Kola kdump tests") {
stage("Kola") {

?

Copy link
Author

@jbtrystram jbtrystram Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make it extra clear for the kdump folks looking at the pipeline where the logs they are interested into are.

This will uses coreOS jenkins instance to run tests on PRs for this repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants