Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note user-specified crashkernel value will be overwritten by default value #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coiby
Copy link
Member

@coiby coiby commented Dec 10, 2024

Resolves: https://issues.redhat.com/browse/RHEL-69568

Suggested-by: Ryosuke Yasuoka [email protected]

@prudo1 prudo1 self-requested a review December 10, 2024 12:41
Copy link
Collaborator

@prudo1 prudo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coiby,

looks good. I'd only prefer to have a more meaningful commit message.

Thanks
Philipp

…value

Resolves: https://issues.redhat.com/browse/RHEL-69568

When kdump-utils gets updated automatically i.e. not updated manually by
user, users won't notice custom crashkernel value gets overwritten as
the logs in /var/log/dnf.rpm.log may be ignored,
    2024-12-10T02:57:12-0500 INFO kdump: For kernel=/boot/vmlinuz-6.11.0-28.el10.x86_64, crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M now. Please reboot the system for the change to take effect. Note if you don't want kexec-tools to manage the crashkernel kernel parameter, please set auto_reset_crashkernel=no in /etc/kdump.conf.

So add a note to kdump.conf.

Suggested-by: Ryosuke Yasuoka <[email protected]>

Signed-off-by: Coiby Xu <[email protected]>
@coiby coiby force-pushed the reset_crashkernel_doc branch from 6380406 to 0606a36 Compare December 11, 2024 07:24
@coiby
Copy link
Member Author

coiby commented Dec 11, 2024

Hi @prudo1,

Thanks for reviewing the patch! I've provided the context in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants