Bind mount and btrfs dump target enhancement #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use findmnt to find the real mount point by mount source, however, when there is a bind mount target, findmnt will give more than one results and what we actually want is the one without fsroot. Will fallback to previous method if the $_mntpoint is empty. Signed-off-by: Lichen Liu <[email protected]>
Move all get_something_from_target() functions to one place. Signed-off-by: Lichen Liu <[email protected]>
get_*_from_target() use findmnt --source to get infomation, but their names sugget they will get info by target, renamed them in order to not confuse readers. Signed-off-by: Lichen Liu <[email protected]>
When using btrfs dump target, we need to use subvol to find the real mntpoint instead of the first output of findmnt, which is almost always root subvol. All functions that call this function are also updated. For user configured btrfs dump target, we don't need the subvol and it will always use the first subvol. Signed-off-by: Lichen Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patch set is aimed at improving bind mount and btrfs dump target.
The 1st patch resolved the same issue with #28.
The 2nd patch and the 3rd patch are doing some renaming work.
The 4th patch tries to resolve the btrfs issue by keeping subvol info when handling kdump target and block device.
For user configured btrfs dump target, currently just leave it as it is, so that it will always use the first subvol. maybe we can add a subvol option in /etc/kdump.conf in the future.