Use SHA512 for storing hashed passwords #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root password and grub password were encrypted using an (insecure) MD5 hash. The resulting kickstart file would build virtual machines that store the (insecure) MD5 hashed password for root in /etc/shadow. Since current operating systems using glibc 2.7 (or later) default to SHA512 hashes for /etc/shadow and support SHA512 for grub, and Python 2.7's crypt function will generate a SHA512 has for any salt starting with '$6$', this patch changes the algorithm to SHA512 for storing hashed passwords.
|
/assign @clumens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root password and grub password were encrypted using
an (insecure) MD5 hash. The resulting kickstart file would
build virtual machines that store the (insecure) MD5
hashed password for root in /etc/shadow.
Since current operating systems using glibc 2.7 (or later)
default to SHA512 hashes for /etc/shadow and support SHA512
for grub, and Python 2.7's crypt function will generate a
SHA512 has for any salt starting with '$6$', this patch
changes the algorithm to SHA512 for storing hashed passwords.