dump: Use exception's type and value when calculating hash #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has caused problems with later versions of Anaconda as the traceback always leads to the same handler and without the exception type and value there is no distinction between the errors. I do not think that including the type is problematic at all. Including the value can result in some duplicates not being detected as the message can contain anything. But not including it will cause much more false duplicates, so I think it is better to include it. Resolves: rhbz#1848493
mzidek-gh
force-pushed
the
dump_hash_fix
branch
from
0cfa256 to
7870499
Compare
M4rtinK
approved these changes
Sep 23, 2020
poncovka
approved these changes
Sep 24, 2020
VladimirSlavik
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has caused problems with later versions of Anaconda
as the traceback always leads to the same handler and
without the exception type and value there is no distinction
between the errors.
I do not think that including the type is problematic
at all.
Including the value can result in some duplicates not
being detected as the message can contain anything.
But not including it will cause much more false
duplicates, so I think it is better to include it.
Resolves: rhbz#1848493