Improve the language screen from new design #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamkankovsky
commented
Nov 28, 2024
adamkankovsky
commented
Change gouping to suggested and others. Added translations to the side. Create custom search component (stop using menu search).
adamkankovsky
force-pushed
the
language-improvements
branch
from
816f576
to
a8fd649
Compare
KKoukiou
reviewed
Nov 29, 2024
| } from "@patternfly/react-core"; | ||
| import { CheckIcon, SearchIcon } from "@patternfly/react-icons"; |
There was a problem hiding this comment.
Can you import it with the above icons grouped?
| </React.Fragment> | ||
| ); | ||
| } | ||
|
|
||
| // List alphabetically. | ||
| const languagesIds = Object.keys(languages).sort(); |
There was a problem hiding this comment.
@garrett should alphabetical sorting persist or not?
KKoukiou
reviewed
Dec 2, 2024
| )} | ||
| </div> | ||
| <span id="item-translation"> | ||
| {getLanguageEnglishName(locale)} |
There was a problem hiding this comment.
@garrett i think we need some clarification here.
What it the right column? IN the mockups it's inconsistent, sometimes translated locale to english, sometimes the native. Please clarify.
Also we would need some help to restrain the height of the menu, as it currently spans larger than the available space, and it creates the common issue with the double scrollbar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.