Prepare for the blivet-gui / cockpit-storage migration #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KKoukiou
force-pushed
the
storage-pre-cockpit-cleanup
branch
from
11a1e1a to
1e31290
Compare
rvykydal
requested changes
Jan 30, 2024
There was a problem hiding this comment.
The PR failed for me locally with #147 (described also in #72 (comment))
I guess we either need to make mountPointConstraints static (global) again (until we need them more dynamic) as in rvykydal@f8dc002 or to check them for no real change or update somehow the checks in https://github.com/KKoukiou/anaconda-webui/blob/1e312908b8a76a41654e8c109b3483965a00f7dd/src/components/storage/MountPointMapping.jsx#L506. |
In preparation for an upcoming commit introducing a new 'page' for editing storage, this change refines the logic for the initial step when opening the wizard. The goal is to enable users to seamlessly return to their last visited step within the wizard, when briefly stepping out of the flow. This commit achieves the desired behavior by always selecting the last visited step if the wizard is not opening for the first time.
KKoukiou
force-pushed
the
storage-pre-cockpit-cleanup
branch
from
1e31290 to
fc1fd21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.