New software template to add gitlab integration #92
Conversation
ElaiShalevRH
changed the title
ElaiShalevRH
force-pushed
the
gitlab-template
branch
from
ded0335 to
63f0616
Compare
There was a problem hiding this comment.
LGTM
Is there any related PR to be opened to the orchestrator-helm-operator repo? Maybe the tekton https://github.com/parodos-dev/orchestrator-helm-operator/blob/main/helm-charts/orchestrator/templates/tekton-pipeline.yaml#L37
|
I opened this PR to the operator about the tekton pipline, do we need to update that pipeline with every change to the templates/operator? I haven't done so for the create Quay story |
I guess not but I was wondering if GH and GL had different behaviour when we want to fetch and push or if all the tokens are passed correctly |
|
On rhdh I tested e2e by adding the gitlab integration to the app-config-rhdh-auth. I haven't tested my operator changes, but that is not related to the veracity of the templates changes |
With gitops enabled? So the tekton pipeline was executed fine and argoCD deployed the workflow on the cluster as expected as well?
yes, that's unrelated to the pipelines, just the deployment of RHDH |
I may have not tested that part to completion. Maybe we should hold until |
ElaiShalevRH
force-pushed
the
gitlab-template
branch
2 times, most recently
from
5651b72 to
3c22f80
Compare
scaffolder-templates/skeletons/basic-workflow-skeleton/catalog-info.yaml
Show resolved
Hide resolved
| convertToFlat: false | ||
| targetPath: workflow | ||
| - id: addCIPipeline | ||
| name: Adding the gitlab pipeline for the Workflow |
There was a problem hiding this comment.
generally speaking, we wanted shorten titles for steps (more concise so they fit into the screen)
Closes https://issues.redhat.com/browse/FLPATH-1823
New Software Template to allow creating a Advanced and basic workflows with Gitlab integration (instead of github).
The user will provide as input the gitlab group, instance (host), and new project name of their choosing,
the workflow will use the software template to create the new software project in the provided gitlab location,
It will also create a new API token and gitlab variable to run a CI pipeline.
Actual Code changes:
adding the gitlab-workflow/ dir, gitlab-workflow/template.yaml, build/.ci-gitlab.yml, catalog-info.yaml files
There were some directory tree changes