Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD Version v1alpha2 #425

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Conversation

jenniferubah
Copy link
Collaborator

@jenniferubah jenniferubah commented Dec 16, 2024

With the recent changes to RHDH plugins, we are now enabling the notifications, notifications-backend and notificatinemail plugins and signals/signal backends plugins by default. Hence no longer allowing the admin to configure these values via the CR/CRD. As this is a breaking change, we introduce the v1alpha2 version of the CRD, remove these values from the CRD and values.yaml files. We also added the new custom plugins orchestrator.

  • Updated rhdh-operator manifest using this example

@jenniferubah jenniferubah marked this pull request as ready for review December 16, 2024 20:43
@pkliczewski
Copy link
Collaborator

@jordigilh please rereview this PR

@jianrongzhang89
Copy link

jianrongzhang89 commented Dec 17, 2024

@jenniferubah @pkliczewski @masayag @jordigilh why are we introducing version v1alpha2? Will it replace v1aplah1, or both version will co-exist? Do we have customers who already use v1alpha1, and if so how do they migrate to v1alpha2? Thanks.

@jordigilh
Copy link
Collaborator

@jenniferubah @pkliczewski @masayag @jordigilh why are we introducing version v1alpha2? Will it replace v1aplah1, or both version will co-exist? Do we have customers who already use v1alpha1, and if so how do they migrate to v1alpha2? Thanks.

As discussed internally, we have agreed to raise the version due to the changes introduced here.

@jianrongzhang89
Copy link

@jenniferubah @pkliczewski @masayag @jordigilh why are we introducing version v1alpha2? Will it replace v1aplah1, or both version will co-exist? Do we have customers who already use v1alpha1, and if so how do they migrate to v1alpha2? Thanks.

As discussed internally, we have agreed to raise the version due to the changes introduced here.

Sounds good. Thank you @jordigilh

@pkliczewski
Copy link
Collaborator

@jordigilh do you think this change is ready? it is needed to release first RC build. it would be great to do it as soon as possible

Copy link
Collaborator

@jordigilh jordigilh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jenniferubah jenniferubah merged commit bfe191e into rhdhorchestrator:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants