-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD Version v1alpha2 #425
CRD Version v1alpha2 #425
Conversation
c1a216c
to
354724d
Compare
config/manifests/bases/orchestrator-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
config/manifests/bases/orchestrator-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
b89c889
to
cd5ceed
Compare
4c33f8e
to
b88c100
Compare
@jordigilh please rereview this PR |
@jenniferubah @pkliczewski @masayag @jordigilh why are we introducing version v1alpha2? Will it replace v1aplah1, or both version will co-exist? Do we have customers who already use v1alpha1, and if so how do they migrate to v1alpha2? Thanks. |
As discussed internally, we have agreed to raise the version due to the changes introduced here. |
Sounds good. Thank you @jordigilh |
@jordigilh do you think this change is ready? it is needed to release first RC build. it would be great to do it as soon as possible |
7964ea0
to
0bc2f98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
0bc2f98
to
d0fb2a3
Compare
With the recent changes to RHDH plugins, we are now enabling the notifications, notifications-backend and notificatinemail plugins and signals/signal backends plugins by default. Hence no longer allowing the admin to configure these values via the CR/CRD. As this is a breaking change, we introduce the v1alpha2 version of the CRD, remove these values from the CRD and
values.yaml
files. We also added the new custom plugins orchestrator.