Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLPATH-1856 Enabling monitoring by default in Helm Based Orchestrator operator #422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ endif

# Set the Operator SDK version to use. By default, what is installed on the system is used.
# This is useful for CI or a project to utilize a specific version of the operator-sdk toolkit.
OPERATOR_SDK_VERSION ?= v1.35.0
OPERATOR_SDK_VERSION ?= v1.37.0

# Image URL to use all building/pushing image targets
IMG ?= $(IMAGE_TAG_BASE):$(VERSION)
Expand Down
19 changes: 11 additions & 8 deletions bundle/manifests/orchestrator-operator.clusterserviceversion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ metadata:
"orchestrator": {
"namespace": "sonataflow-infra",
"sonataflowPlatform": {
"monitoring": {
"enabled": true
},
"resources": {
"limits": {
"cpu": "500m",
Expand Down Expand Up @@ -131,7 +134,7 @@ metadata:
capabilities: Basic Install
categories: Developer Tools
console.openshift.io/disable-operand-delete: "true"
createdAt: "2024-12-19T16:28:07Z"
createdAt: "2024-12-20T00:49:45Z"
features.operators.openshift.io/cnf: "false"
features.operators.openshift.io/cni: "false"
features.operators.openshift.io/csi: "false"
Expand All @@ -155,16 +158,16 @@ metadata:
operatorframework.io/arch.ppc64le: unsupported
operatorframework.io/arch.s390x: unsupported
operatorframework.io/suggested-namespace: orchestrator
name: orchestrator-operator.v1.3.0
name: orchestrator-operator.v1.4.0-rc1
namespace: placeholder
spec:
apiservicedefinitions: {}
customresourcedefinitions:
owned:
- description: RHDH Orchestrator introduces serverless asynchronous workflows to Backstage,
with a focus on facilitating the transition of applications to the cloud,
onboarding developers, and enabling users to create workflows for backstage
actions or external systems.
- description: RHDH Orchestrator introduces serverless asynchronous workflows
to Backstage, with a focus on facilitating the transition of applications
to the cloud, onboarding developers, and enabling users to create workflows
for backstage actions or external systems.
displayName: Orchestrator
kind: Orchestrator
name: orchestrators.rhdh.redhat.com
Expand Down Expand Up @@ -477,7 +480,7 @@ spec:
- --metrics-bind-address=127.0.0.1:8080
- --leader-elect
- --leader-election-id=orchestrator-operator
image: quay.io/orchestrator/orchestrator-operator:1.3.0
image: quay.io/orchestrator/orchestrator-operator:1.4.0-rc1
livenessProbe:
httpGet:
path: /healthz
Expand Down Expand Up @@ -566,4 +569,4 @@ spec:
provider:
name: Red Hat
url: https://www.redhat.com
version: 1.3.0
version: 1.4.0-rc1
9 changes: 9 additions & 0 deletions bundle/manifests/rhdh.redhat.com_orchestrators.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@ spec:
Job Service container image to be used instead of the provided
one by SonataFlow
type: string
monitoring:
description: Contains the monitoring configuration fields
properties:
enabled:
default: true
description: Enabled determines whether monitoring should
be enabled. Defaults to true.
type: boolean
type: object
resources:
description: Resources contains the requests and limit of
CPU and memory resources for the pod instance
Expand Down
8 changes: 8 additions & 0 deletions config/crd/bases/rhdh.redhat.com_orchestrators.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,14 @@ spec:
sonataflowPlatform:
description: SonataflowPlatform contains the pod resource configuration to be used for the data index and job services
properties:
monitoring:
description: Contains the monitoring configuration fields
properties:
enabled:
description: Enabled determines whether monitoring should be enabled. Defaults to true.
default: true
type: boolean
type: object
resources:
description: Resources contains the requests and limit of CPU and memory resources for the pod instance
type: object
Expand Down
2 changes: 1 addition & 1 deletion config/manager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ kind: Kustomization
images:
- name: controller
newName: quay.io/orchestrator/orchestrator-operator
newTag: 1.3.0
newTag: 1.4.0-rc1
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ spec:
apiservicedefinitions: {}
customresourcedefinitions:
owned:
- description: RHDH Orchestrator introduces serverless asynchronous workflows to Backstage,
with a focus on facilitating the transition of applications to the cloud,
onboarding developers, and enabling users to create workflows for backstage
actions or external systems.
- description: RHDH Orchestrator introduces serverless asynchronous workflows
to Backstage, with a focus on facilitating the transition of applications
to the cloud, onboarding developers, and enabling users to create workflows
for backstage actions or external systems.
displayName: Orchestrator
kind: Orchestrator
name: orchestrators.rhdh.redhat.com
Expand Down
2 changes: 2 additions & 0 deletions config/samples/_v1alpha2_orchestrator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ spec:
orchestrator:
namespace: "sonataflow-infra" # Namespace where sonataflow's workflows run. The value is captured when running the setup.sh script and stored as a label in the selected namespace. User can override the value by populating this field. Defaults to `sonataflow-infra`.
sonataflowPlatform:
monitoring:
enabled: true
resources:
requests:
memory: "64Mi"
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/orchestrator/templates/sonataflows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ metadata:
annotations:
"meta.helm.sh/release-name": {{ .Release.Name}}
spec:
monitoring:
enabled: {{ .Values.orchestrator.sonataflowPlatform.monitoring.enabled }}
build:
template:
resources:
Expand Down
3 changes: 3 additions & 0 deletions helm-charts/orchestrator/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1181,6 +1181,9 @@
"orchestrator": {
"namespace": "sonataflow-infra",
"sonataflowPlatform": {
"monitoring": {
"enabled": false
},
"resources": {
"requests": {
"memory": "64Mi",
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/orchestrator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ postgres:
orchestrator:
namespace: "sonataflow-infra" # Namespace where sonataflow's workflows run. The value is captured when running the setup.sh script and stored as a label in the selected namespace. User can override the value by populating this field. Defaults to `sonataflow-infra`.
sonataflowPlatform:
monitoring:
enabled: true
resources:
requests:
memory: "64Mi"
Expand Down