Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell Bell Clean up / Simplification and Tests #5924

Open
wants to merge 6 commits into
base: upcoming
Choose a base branch
from

Conversation

AlexOn1ine
Copy link
Collaborator

Removes some Shell Bell redundancy, adds test and fixes bug with Multi Hit moves. This is only possible on upcoming.

@AlexOn1ine AlexOn1ine added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes type: cleanup labels Jan 1, 2025
test/battle/hold_effect/shell_bell.c Outdated Show resolved Hide resolved
test/battle/hold_effect/shell_bell.c Show resolved Hide resolved
test/battle/hold_effect/shell_bell.c Outdated Show resolved Hide resolved
@AlexOn1ine
Copy link
Collaborator Author

review comments addressed

@Bassoonian
Copy link
Collaborator

Fails to compile (+ conflicts)

@AlexOn1ine
Copy link
Collaborator Author

Fixed compile + conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants