Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy customizable Hidden Move types #5872

Open
wants to merge 2 commits into
base: upcoming
Choose a base branch
from

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

This is something I tried to do since May but I couldn't figure out the correct algorithm until now.

Things to note in the release changelog:

  • gTypesInfo now has a isHiddenPowerType field that inserts them into the Hidden Power type calculation.
    • Warning: Changing this from the vanilla settings will change any existing Hidden Power's type, and external calculators will not work either.

Discord contact info

AsparagusEduardo

@AlexOn1ine
Copy link
Collaborator

Would it make sense to rewrite the test Hidden Power's type is determined by IVs a little bit? For example Steel resists Dragon but Steel was also used to test the Rock Hidden Power, meaning we don't exactly know which is which. So more unique combinations would make it less likely to have an error.

This is optional though and not blocking.

@AsparagusEduardo
Copy link
Collaborator Author

Would it make sense to rewrite the test Hidden Power's type is determined by IVs a little bit? For example Steel resists Dragon but Steel was also used to test the Rock Hidden Power, meaning we don't exactly know which is which. So more unique combinations would make it less likely to have an error.

This is optional though and not blocking.

Let me find what type combinations can be made to check the specific types

@AsparagusEduardo
Copy link
Collaborator Author

That was a short quest 😂
There's no type combination that is either:

  • Has no weaknesses excluding Flying
  • Has no resistances excluding Flying
  • Has no immunities excluding Flying

Since this is an unsolvable issue, I think checking 4 sets of IVs per type helps minimize potential false-positives.

@hedara90 hedara90 added the category: battle-mechanic Pertains to battle mechanics label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants