Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate move data #5852

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Added fuctions for data access for gMovesInfo.

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo marked this pull request as ready for review December 24, 2024 12:33
@AsparagusEduardo
Copy link
Collaborator Author

Ready for review

@AsparagusEduardo AsparagusEduardo force-pushed the _RHH/pr/upcoming/encapsulateMoveData branch from 8d9f381 to 1896ca0 Compare December 27, 2024 11:24
@AsparagusEduardo AsparagusEduardo changed the title [WIP] Encapsulate move data Encapsulate move data Dec 27, 2024
@AsparagusEduardo
Copy link
Collaborator Author

Ready for review

Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to do battle_util.c

src/battle_ai_main.c Outdated Show resolved Hide resolved
src/battle_ai_main.c Outdated Show resolved Hide resolved
src/battle_ai_main.c Outdated Show resolved Hide resolved
src/battle_ai_util.c Outdated Show resolved Hide resolved
src/battle_controller_opponent.c Outdated Show resolved Hide resolved
src/battle_controller_player.c Outdated Show resolved Hide resolved
src/battle_controller_player_partner.c Outdated Show resolved Hide resolved
src/battle_script_commands.c Outdated Show resolved Hide resolved
src/battle_tower.c Outdated Show resolved Hide resolved
include/battle.h Outdated Show resolved Hide resolved
include/battle.h Outdated Show resolved Hide resolved
src/battle_util.c Outdated Show resolved Hide resolved
@AlexOn1ine
Copy link
Collaborator

Could you solve conflicts? I'll merge right after it

@AsparagusEduardo
Copy link
Collaborator Author

Could you solve conflicts? I'll merge right after it

Done 👍

@AlexOn1ine AlexOn1ine merged commit 9669a05 into rh-hideout:upcoming Jan 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: move effect Pertains to move effects type: big feature A feature with big diffs and / or high impact / subjectivity / pervasiveness type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants