forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate move data #5852
Merged
AlexOn1ine
merged 49 commits into
rh-hideout:upcoming
from
AsparagusEduardo:_RHH/pr/upcoming/encapsulateMoveData
Jan 1, 2025
Merged
Encapsulate move data #5852
AlexOn1ine
merged 49 commits into
rh-hideout:upcoming
from
AsparagusEduardo:_RHH/pr/upcoming/encapsulateMoveData
Jan 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsparagusEduardo
added
category: move effect
Pertains to move effects
type: cleanup
labels
Dec 22, 2024
Ready for review |
AlexOn1ine
reviewed
Dec 26, 2024
AsparagusEduardo
force-pushed
the
_RHH/pr/upcoming/encapsulateMoveData
branch
from
December 27, 2024 11:24
8d9f381
to
1896ca0
Compare
Ready for review |
AlexOn1ine
reviewed
Dec 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have to do battle_util.c
AlexOn1ine
reviewed
Dec 29, 2024
AlexOn1ine
reviewed
Dec 30, 2024
Could you solve conflicts? I'll merge right after it |
Done 👍 |
AlexOn1ine
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: move effect
Pertains to move effects
type: big feature
A feature with big diffs and / or high impact / subjectivity / pervasiveness
type: cleanup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added fuctions for data access for
gMovesInfo
.Discord contact info
AsparagusEduardo