Battle Weather Refactor

[AlexOn1ine]

Description

Battler Weather Refactor

Simplifies battle weather flags by removing perma and temp flags. Permanence is checked with weatherDuration > 0
The advantage is that it is much easier to add new weather flags and it cleans up some code.

Small problem I had that I couldn't solve:

-TryChangeBattleWeather(u32 battler, u32 battleWeatherId, bool32 viaAbility);
+TryChangeBattleWeather(u32 battler, enum BattleWeather battleWeatherId, bool32 viaAbility); 

The compiler didn't want to cooperate with this change with the following error message:

include/battle_util.h:204:49: error: 'enum BattleWeather' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
  204 | bool32 TryChangeBattleWeather(u32 battler, enum BattleWeather weatherEnumId, bool32 viaAbility);

[ghoulslash]

Hm looks like it messed up an AI calc

  - test/battle/ai/ai.c:286: Unmatched SCORE_EQ, got Psychic: 107, Solar Beam: 106 - AI chooses the safest option to faint the target, taking into account accuracy and move effect 3/5.

[AlexOn1ine]

Hm looks like it messed up an AI calc

  - test/battle/ai/ai.c:286: Unmatched SCORE_EQ, got Psychic: 107, Solar Beam: 106 - AI chooses the safest option to faint the target, taking into account accuracy and move effect 3/5.

Fixed.

For Some reason reordering flags caused the AI not seeing that Solar Beam can be used without a charge in weather.

.argument = TWO_TURN_ARG(STRINGID_PKMNTOOKSUNLIGHT, B_WEATHER_SUN)

This part was responsible. I hard-coded the solar beam check for sun and it passed fine.
I don't think this is an issue with the refactor though and would have been the same problem with the old flags reordered.

[AlexOn1ine]

@ghoulslash thoughts on consolidating

    ENDTURN_RAIN,
    ENDTURN_SANDSTORM,
    ENDTURN_SUN,
    ENDTURN_HAIL,
    ENDTURN_SNOW,
    ENDTURN_FOG,

into just ENDTURN_WEATHER?

[AlexOn1ine]

Pushed a draft version. Still need to clean up and handle damaging weather but let me know if this is acceptable.

[ghoulslash]

Probably better as a struct

[AlexOn1ine]

Could you give me a hint on how I should structure it?

[AlexOn1ine]

Changed it to a struct. Let me know if this is what you imagined

(still no clean up)

[ghoulslash]

Why are these commented out?

[AlexOn1ine]

those scripts are unused. I just commented stuff out that I already deleted but I didn't want to do any further clean up.

[AlexOn1ine]

Ready for re-review