forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trainer Party Pools #5731
Open
hedara90
wants to merge
24
commits into
rh-hideout:upcoming
Choose a base branch
from
hedara90:tpp-new
base: upcoming
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Trainer Party Pools #5731
+1,528
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
reviewed
Nov 28, 2024
fakuzatsu
reviewed
Dec 5, 2024
…em, and some pool picking fixes
Preliminarily ready for review.
Replacement trainer for Tiana for testing.
|
(Almost) ready for review, just missing pool verification. |
pkmnsnfrn
added
the
type: big feature
A feature with big diffs and / or high impact / subjectivity / pervasiveness
label
Dec 20, 2024
Ready for review. |
Split all the pool functions into its own file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new-feature
Adds a feature
type: big feature
A feature with big diffs and / or high impact / subjectivity / pervasiveness
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows trainers to generate their party from a curated pool of pokemon defined in the trainer party.
This feature changes nothing about
trainers.party
ortrainers.h
if it's not used.To use this feature, simply define a
Party Size
that lower than the amount of defined pokemon for the trainer intrainers.party
or.partySize
and.poolSize
intraners.h
wherepoolSize
is larger thanpartySize
and matches the number of defined pokemon.Optionally
Pool Rules
can be defined for the trainer to change which rules should be applied to the trainer.Mons in the pool can have tags that change how the party is picked from the pool.
If a mon has the tag
Lead
the first mon in the party will be picked from all the pool members with this tag.If a mon has the tag
Ace
the last member of the party will be picked from all the pool members with this tag.Other tags can be marked as
POOL_TAG_REQUIRED
instruct PoolRules poolRules
which will force that tag to be included as early as possible. (Not completely implemented right now)Rules for the pools also include forcing unique species or NatDex numbers and unique items.
Items can also be excluded from the item uniqueness with a list.
Pool max size is currently set to 64 in
trainerproc
. But party generation is limited to a maximum size of 255 since index 255 is used for "No mon chosen yet".Images
Things to note in the release changelog:
docs/tutorials/how_to_trainer_party_pool.md
Discord contact info
hedara